#25425: Enforce calling resolve_expression before as_sql on all expressions
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by akaariai):
We have two interfaces:
- Resolvable: resolved to an expression with resolve_expression
- Compilable: can be turned into SQL
Not all compilables are resolvables, nor the other way around. So, it
doesn't make sense to enforce that all compilables have been resolved.
I'm not even sure what WhereNode.resolve_expression() would do? We have
other similar types that are not resolved ever, for example BaseTable and
Join.
We could do the check for those cases where we have the resolve + compile
contract.
--
Ticket URL: <https://code.djangoproject.com/ticket/25425#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.dace88662c872641aa84d54ed10f0d66%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
