#25478: 1.8 migrating doc code sample needs parens
-------------------------------+--------------------
     Reporter:  nedbatchelder  |      Owner:  nobody
         Type:  Uncategorized  |     Status:  new
    Component:  Documentation  |    Version:  1.8
     Severity:  Normal         |   Keywords:
 Triage Stage:  Unreviewed     |  Has patch:  0
Easy pickings:  0              |      UI/UX:  0
-------------------------------+--------------------
 I think this sample from
 https://docs.djangoproject.com/en/1.8/ref/models/meta/#migrating-from-the-
 old-api needs parens to be correct. The docs have:
 {{{
 [
     (f, f.model if f.model != MyModel else None)
     for f in MyModel._meta.get_fields()
     if not f.is_relation
         or f.one_to_one
         or (f.many_to_one and f.related_model)
 ]
 }}}
 but the condition seems wrong. Shouldn't it be:
 {{{
 [
     (f, f.model if f.model != MyModel else None)
     for f in MyModel._meta.get_fields()
     if not (f.is_relation
         or f.one_to_one
         or (f.many_to_one and f.related_model)
     )
 ]
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25478>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.d0fcfb3c24a72b07090538838553d2c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to