#25478: 1.8 migrating doc code sample needs parens
-------------------------------+--------------------------------------
Reporter: nedbatchelder | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by nedbatchelder):
* status: closed => new
* resolution: worksforme =>
Comment:
I didn't mean that it was a syntax error. I meant that the logic was
wrong. Without the parens, the condition is equivalent to:
{{{
(not f.is_relation) or (f.one_to_one) or (f.many_to_one and
f.related_model)
}}}
Don't we actually want:
{{{
not (f.is_relation or f.one_to_one or (f.many_to_one and f.related_model))
}}}
That is, the field should be excluded if it's a relation or if it's one-
to-one, or if it's both many-to-one and related.
--
Ticket URL: <https://code.djangoproject.com/ticket/25478#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.8d1412a4cd8dd24d47f14631b00580f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
