#25882: Deletion on ForeignKey raises TypeError
-------------------------------------+-------------------------------------
     Reporter:  gerricom             |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  1.9
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by charettes):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * severity:  Normal => Release blocker
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 It looks like
 
[https://github.com/django/django/commit/04e8d890aec8e996d568565555164a27a6a76057
 the fix] for #16891 didn't account for the fact
 `django.db.models.sql.subqueries.DeleteQuery.delete_qs` can
 
[https://github.com/django/django/blob/59b57e672c2f5a685804cce253d2c5314c45c5fa/django/db/models/sql/subqueries.py#L68-L71
 return None].

 Not sure if this should be fixed at the `Collector` or `DeleteQuery`
 level.

--
Ticket URL: <https://code.djangoproject.com/ticket/25882#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.43ede4b04381349b71cc4a76b8d989e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to