#26293: Warnings regarding 404s logged for URLs missing trailing slashes -------------------------------------+------------------------------------- Reporter: jklaiho | Owner: the-kid89 Type: Bug | Status: assigned Component: HTTP handling | Version: 1.9 Severity: Normal | Resolution: Keywords: CommonMiddleware | Triage Stage: 404 logging regression | Unreviewed Has patch: 1 | Needs documentation: 0 Needs tests: 1 | Patch needs improvement: 0 Easy pickings: 1 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by jklaiho): I haven't tested your changes, but by my reading of the code, it looks incorrect. After your unindentation, `process_request` now '''always''' returns a `HttpResponsePermanentRedirect`, as long as the forbidden UA check at the top passes. It should only do that when either the slash has been appended or "www" has been prepended. -- Ticket URL: <https://code.djangoproject.com/ticket/26293#comment:6> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.0ea5c33534a14772d1d87e8ba1cd9123%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.