#26520: SessionBase.pop() no longer raises a KeyError
-------------------------------------+-------------------------------------
Reporter: tuky | Owner: nobody
Type: Bug | Status: new
Component: contrib.sessions | Version: 1.9
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
Old description:
> The fix of https://code.djangoproject.com/ticket/24621 led to always
> providing a default to session's dict method pop. This prevents a
> KeyError to ever be thrown, which should be expected by a pop-function.
>
> Pull request is https://github.com/django/django/pull/6480
New description:
The fix of #24621 led to always providing a `default` to session's dict's
`pop()` method. This prevents a `KeyError` from ever being raised, which
should be expected by a pop-function.
Pull request is https://github.com/django/django/pull/6480
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26520#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.027dd0aa3d9f95311e876f2df7ae4d91%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
