#26632: System check for list_display_links ignores value of
ModelAdmin.get_list_display()
-------------------------------+------------------------------------
     Reporter:  zachborboa     |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  1.9
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by timgraham):

 * needs_better_patch:   => 0
 * component:  Uncategorized => contrib.admin
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 I don't think we can check these methods because we'd need an
 `HttpRequest`.

 As [https://groups.google.com/d/msg/django-developers/WrnhmTyLHuY/LI-
 MROj_J1cJ Luke said], "I think the problems with the false negatives for
 the admin checks may need to be solved another way - namely by removing
 them. That's unfortunate, but I found them tricky in the past - they may
 prevent common errors, but they also prevent more advanced ways that you
 might want to use the admin."

 Maybe we could try disabling each check if the method version of check's
 attribute is defined.

--
Ticket URL: <https://code.djangoproject.com/ticket/26632#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.35829a2ca0ed4acbbcb6648e4b045949%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to