#26986: `force_login` requires `user.is_active` in 1.10
--------------------------------------+------------------------------------
     Reporter:  Tordek                |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Documentation         |                  Version:  1.10
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by Tordek):

 I see, that makes sense; this

 {{{
 * The new :class:`~django.contrib.auth.backends.AllowAllUsersModelBackend`
 and
   :class:`~django.contrib.auth.backends.AllowAllUsersRemoteUserBackend`
 ignore
   the value of ``User.is_active``, while
   :class:`~django.contrib.auth.backends.ModelBackend` and
   :class:`~django.contrib.auth.backends.RemoteUserBackend` now reject
 inactive
   users.
 }}}

 would be the relevant item in the changelog.

 My issue in particular is the disconnect between the symptom
 (`force_login` "stopped working") and the cause (the backend's behavior
 changed).

 Would an item mentioning something like "test cases using `force_login()`
 uses may need to be updated to use an active user" make sense?

--
Ticket URL: <https://code.djangoproject.com/ticket/26986#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2d38f27e041c329782e0ec707c9f35f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to