#26998: admin.E013 check false positive on django-taggit
-------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by jonathanmorgan):
I use django-taggit and want it to keep working going forward, and so I am
willing to try making a patch for this:
I think we should revert the entire checks.py file changes except for
admin.E003 and admin.E020. (I think the "must be m2m" checks should allow
all many_to_many, and the "can't be m2m" checks should only check
ManyToManyField.). That way django allows more custom fields.
if it is as straightforward as it sounds (revert everything but the
changes at lines 107-108 and lines 298-299, then see if that conflicts
with other subsequent changes?). I've not contributed before, however, so
I might need some guidance as I'm working through the documentation on how
to contribute. For example, I don't really understand what is going on
here well enough to make a test, and so if a test is needed here as part
of the patch, I'm probably not the right person to do this work.
Let me know if you think I can be of help.
--
Ticket URL: <https://code.djangoproject.com/ticket/26998#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.463c970e079b11b8ad3751d76bbc2d1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
