#27142: makemigrations fails on special database connections
---------------------------------+------------------------------------
Reporter: gerricom | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.10
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):
* needs_tests: 1 => 0
Comment:
Some tests are added and the patch might be ready for review, however, I
think the addition of consistency checks in `makemigrations`, even with
these changes, could remain backwards-incompatible in some edge cases. For
example, a project with a read-only database that defines some database
routers but hasn't setup a router to prevent migrating on the read-only
database will need to add a rule in a router's `allow_migrate()` to
prevent the consistency check. Previously, I think Django would be usable
without such a rule (of course, a developer could break things by making a
mistake like invoking `manage.py migrate --database=readonly_database`). I
guess anyone in favor of this check in `makemigrations` would deem the
backwards-incompatibility acceptable, provided a note is added in the
release notes.
--
Ticket URL: <https://code.djangoproject.com/ticket/27142#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.1ba568631cb4d79b48cf4d325b2c767e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
