#27743: CSS fix of "viewsitelink", "golink" and "addlink" buttons for Django 
admin
-------------------------------------+-------------------------------------
               Reporter:  Nick       |          Owner:  nobody
  Mavrakis                           |
                   Type:             |         Status:  new
  Cleanup/optimization               |
              Component:             |        Version:  master
  contrib.admin                      |       Keywords:  admin, css,
               Severity:  Normal     |  background-position, icon
           Triage Stage:             |      Has patch:  1
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  1
                  UI/UX:  1          |
-------------------------------------+-------------------------------------
 This is a minor fix but, in my opinion, its very helpful!

 Inside the Django admin change list page, in the upper right corner (ADD
 OBJECT button), if the text is too long then the "+" icon overlaps the
 text as you can see in the image. This is due to the `background-position:
 93% center`
 
(https://github.com/django/django/blob/master/django/contrib/admin/static/admin/css/base.css#L741).

 PROPOSED FIX: Because `background-position` can take up to 4 values due to
 `background position edge offsets` (http://caniuse.com/#feat=css-
 background-offsets), we can change the above line to:

 `background-position: right 7px center;`

 The same applies to the other button, `VIEW ON SITE`
 
(https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.view_on_site),
 as well.

--
Ticket URL: <https://code.djangoproject.com/ticket/27743>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.59f4749f5b92cfa30ccf5dac8bd3614c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to