#28105: Missing check in django.contrib.forms.widgets
-------------------------------------+-------------------------------------
Reporter: Dylan | Owner: nobody
Verheul |
Type: Bug | Status: new
Component: Forms | Version: 1.11
Severity: Normal | Keywords: gis, forms, widgets
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
In django.contrib.forms.widgets there is this part (line 67 in corrent
master):
context = self.build_attrs(self.attrs, dict(
name=name,
module='geodjango_%s' % name.replace('-', '_'), # JS-safe
serialized=self.serialize(value),
geom_type=gdal.OGRGeomType(self.attrs['geom_type']),
STATIC_URL=settings.STATIC_URL,
LANGUAGE_BIDI=translation.get_language_bidi(),
**attrs
))
If `attrs` also contains a key 'geom_type' this leads to an inevitable
crash.
This should probaly be something like:
context_kwargs = attrs.copy()
context_kwargs.upgrade(dict(
name=name,
module='geodjango_%s' % name.replace('-', '_'), # JS-safe
serialized=self.serialize(value),
geom_type=gdal.OGRGeomType(self.attrs['geom_type']),
STATIC_URL=settings.STATIC_URL,
LANGUAGE_BIDI=translation.get_language_bidi(),
))
Currently this causes django-bootstrap3 to fail for Django 1.11.
--
Ticket URL: <https://code.djangoproject.com/ticket/28105>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/047.498bfa805d9fcd13c42494ff20aa818b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
