#28099: Reuse of UpdateQuery breaks complex delete updates
-------------------------------------+-------------------------------------
     Reporter:  milosu               |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  1.11
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


Comment:

 I haven't investigated this is detail but it would be nice to understand
 the root cause of the issue a bit more to confirm that the fix is the best
 one. The patch should be reworked to apply to master (which supports
 Python 3 only) and the test simplified as much as possible. Existing test
 models should be used as much as possible. If any new models are needed
 they should have as few fields as possible. The test should use `create()`
 rather than `get_or_create()` and I don' think the `DoesNotExist`
 exception catching is necessary.

--
Ticket URL: <https://code.djangoproject.com/ticket/28099#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.468ec93821521919d7b5b4dea5fa1cfe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to