#28344: Add for_update parameter to Model.refresh_from_db()
-------------------------------------+-------------------------------------
     Reporter:  Patryk Zawadzki      |                    Owner:  felixxm
         Type:  New feature          |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

 * version:  1.11 => master


Comment:

 Count me -0 on adding this given all the available `select_for_update()`
 options. I fear we might open a can of worms here and have to either say
 no to `nowait`, `skip_locked` and now `of` support in the future or allow
 `for_update` to be a dict delegating kwargs to the underlying
 `select_for_update()` call.

 From my personal experience using `select_for_update()` with
 `refresh_from_db()` is not a common enough pattern to warrant the addition
 of this kwarg. Just me two cents.

--
Ticket URL: <https://code.djangoproject.com/ticket/28344#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0b80a4fade2e722a346801b06c8bd127%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to