#29033: Sitemap framework does not properly detect secure requests
--------------------------------------------+------------------------
Reporter: Matt Magin | Owner: nobody
Type: Bug | Status: new
Component: contrib.sitemaps | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
Django settings provides the option of overriding the detected protocol by
setting SECURE_PROXY_SSL_HEADER, however contrib.sitemaps just defaults to
'http' if the protocol in the Sitemap class is not overridden.
Ideally contrib.sitemaps would use the request.is_secure() method to
detect the protocol in the request and default to that instead.
I would be happy to provide a patch but I feel some discussion is
required. The sitemap.xml views are easily fixed, however complexity is
added when updating the defaults in get_urls on the Sitemap object as it
doesn't have access to the request object.
--
Ticket URL: <https://code.djangoproject.com/ticket/29033>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/048.dddf374e2f0f87f705cc263907477703%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
