#29260: Django makes an extra UPDATE query when custom PK is evaluating before
save.
-------------------------------------+-------------------------------------
Reporter: user0007 | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
> A fix might try to detect if the primary key came from a default and if
so, skip the update.
I think we could use some kind of `self._state.adding and
self._meta.pk.default` heuristics to automatically set `force_insert=True`
on the last table/leaf child. That would break the following scenario
though.
{{{#!python
a = Account(pk='known-uuid-pk')
a.title = new_title
a.save() # expects an UPDATE here.
}}}
But I would argue that `force_update` should be passed in this case.
That wouldn't solve the MTI issue described in #29129 but that would do
for this case.
--
Ticket URL: <https://code.djangoproject.com/ticket/29260#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.b636e671f6e23a74a2cae56a6ff38f86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
