#29301: Reorder management command arguments in --help output to prioritize
command-specific arguments
-------------------------------------+-------------------------------------
     Reporter:  David Foster         |                    Owner:  David
         Type:                       |  Foster
  Cleanup/optimization               |                   Status:  assigned
    Component:  Core (Management     |                  Version:  2.0
  commands)                          |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


Comment:

 This looks good to me.

 * Functions correctly with manual testing
 * Command parsing is directly tested in `tests/user_commands/tests.py`.
 That exercises this change, without an explicit tests.

 I'm going to mark it 'Ready for checkin' on that basis.

 Maybe Tim sends it back for:

 * An explicit test. (That custom option appears before, e.g. verbosity for
 command X.)
 * A mention in the release notes at least.

 I wasn't sure on either of these.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29301#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.80be4f444d88c94d3b042b2a1f06afe4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to