#29735: MRO of DeleteView need to be changed.
-------------------------------------+-------------------------------------
Reporter: seokhun | Owner: nobody
kim |
Type: | Status: new
Cleanup/optimization |
Component: Generic | Version: 2.1
views | Keywords: deletemixin,
Severity: Normal | basedeleteview, deleteview, generic
Triage Stage: | view
Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
(Please refer to Pull Request: MRO of DeleteView was changed)
I think MRO of DeleteView need to be changed in order to clarify the
inheritance hierarchy.
So I refactored BaseDeleteView and DeleteMixin.
* (1) What is better as the super class of BaseDeleteView ?
* Currently BaseDeleteView inherits from BaseDetailView.
* I think SingleObjectMixin is sufficient.
* I think Inheritance of Mixin is better than generic view itself.
* So I deleted BaseDetailView in the super class of BaseDeleteView.
* In order to inherit SingleObjectMixin instead of BaseDetailView,
* BaseDeleteView inherits from DeletionMixin.
* DeletionMixin inherits from SingleObjectMixin.
* (2) Where is better on the location of get(), post(), delete() methods ?
* Currently DeleteMixin provides those methods.
* It is bad that Mixin class provides those methods, I think.
* So My change is that BaseDeleteView provides get(), post() and
delete() methods.
--
Ticket URL: <https://code.djangoproject.com/ticket/29735>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/049.fea3efa5d2dd1f4af6d891b56513ab17%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
