#29735: MRO of DeleteView need to be changed.
-------------------------------------+-------------------------------------
Reporter: seokhun kim | Owner: seokhun
Type: | kim
Cleanup/optimization | Status: assigned
Component: Generic views | Version: master
Severity: Normal | Resolution:
Keywords: deletemixin, | Triage Stage:
basedeleteview, deleteview, | Unreviewed
generic view |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):
* stage: Accepted => Unreviewed
Comment:
Please don't mark you own tickets as ''Accepted'', only someone else who
believes the changes are adequate can do it.
I haven't investigated this in details but I'm a bit worried about
changing the MRO and moving the methods off `DeleteMixin` for the sake of
purity. Don't get me wrong, I think that these changes would make sense if
we were to start from scratch but in this case I feel breakage risks
outweigh the benefits.
See the [https://docs.djangoproject.com/en/2.1/internals/contributing
/triaging-tickets/#accepted ticket triaging documentation] for more
details.
--
Ticket URL: <https://code.djangoproject.com/ticket/29735#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.ca98ee0944f742e4c36a28b183f17fc9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
