#29766: Add admonition after submit a new commit
-------------------------------------+-------------------------------------
Reporter: Windson yang | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Hi Windson.
> ... hard to review my code. Instead, I should just create a new
commit...
Sometimes, yes. Often, no. The commit history isn't that helpful for most
patches. For some it is (especially if well crafted).
Whether to push a single commit or steps is a question of judgement. I'm
not sure what we'd add to the docs about that.
I guess I'm inclined to think the advice towards a single commit if the
best baseline. (Allowing individuals to judge otherwise.)
Do you have a specific change in mind?
--
Ticket URL: <https://code.djangoproject.com/ticket/29766#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.59faa8dfe25a4cdf032ffd836cf68985%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
