#29766: Add admonition after submit a new commit
------------------------------------------------+------------------------
Reporter: Windson yang | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I used to use `git rebase -i ` to amend the local commits and `git push
-f` once the maintainer asks me to update a patch. But that makes the
maintainers hard to review my code. Instead, I should just create a new
commit. Then let the maintainers to squash when they merge the diff. I'm
not sure this is my own problem or we should mention the workflow at
[https://docs.djangoproject.com/en/2.1/intro/contributing/#pushing-the-
commit-and-making-a-pull-request]
--
Ticket URL: <https://code.djangoproject.com/ticket/29766>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.d8569bf0e5e76dc7021f919c4380b27c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
