#29866: Database teardown doesn't run if a check errors when running tests
-------------------------------------+-------------------------------------
Reporter: Jayden Kneller | Owner: Jayden
| Kneller
Type: Bug | Status: assigned
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: run_checks tests | Triage Stage: Ready for
teardown database test | checkin
environment |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jayden Kneller):
Just committed your test class name, comment, and doc string changes.
The reason for the class name was because I saw
"Ticket17477RegressionTests" in the same tests file and thought that was
the way to do tickets.
I read through a few pages on the site before doing anything but I'm not
sure I saw anything about naming or wording. I did see the past tense
commit messages. Maybe a little wording/naming guideline would help.
Perhaps somewhere near this section on this page:
https://docs.djangoproject.com/en/2.1/internals/contributing/committing-
code/#committing-guidelines
--
Ticket URL: <https://code.djangoproject.com/ticket/29866#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/070.136628dca6b122fec50bd4055f62c807%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
