#30037: RemoteUserBackend should pass request into configure_user()
-----------------------------------+------------------------------------
     Reporter:  Joshua Cannon      |                    Owner:  nobody
         Type:  New feature        |                   Status:  new
    Component:  contrib.auth       |                  Version:  master
     Severity:  Normal             |               Resolution:
     Keywords:  RemoteUserBackend  |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------
Changes (by Simon Charette):

 * version:  2.1 => master
 * stage:  Unreviewed => Accepted


Comment:

 Now that `authenticate` gets passed `request` I don't see a reason why
 this can't be done for `configure_user`.

 I guess we could reuse `configure_user(request, user)` with a deprecation
 shim that warns about a `configure_user(user)` signature through `inspect`
 reflection just like when the `request` argument was introduced to
 `authenticate` in #25187.

 Here's an example:

 
https://github.com/django/django/commit/4b9330ccc04575f9e5126529ec355a450d12e77c
 #diff-82ec6fd74a1cab41408fbf5bf0998f58R73

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30037#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2b32ba09d498d59b857926c464f18121%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to