#30188: Aggregate annotation, Case() - When(): AssertionError No exception 
message
supplied
-------------------------------------+-------------------------------------
     Reporter:  Lukas Klement        |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.1
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  query, aggregate,    |             Triage Stage:  Accepted
  case/when                          |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Can Sarıgöl):

 Can we fix twice annotated problem in here? I thought that we can remove
 the expr if it is already in annotations ({{{expr == old_expr}}})


 {{{
 elif isinstance(expr, (Col, Subquery)) or (expr.contains_aggregate and not
 expr.is_summary):
  ...
  new_exprs.append(Ref(col_alias, expr))
  if isinstance(expr, Subquery):
      keys = {
          k for k, old_expr in self.annotations.items()
          if k.startswith('__col') is False and expr == old_expr
       }
      for _k in keys:
          del self.annotations[_k]
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30188#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.690a153383c4ae8f16b0933b8de4f8f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to