#30342: Remove the LANGUAGES_BIDI<=LANGUAGES check
------------------------------------------------+------------------------
Reporter: Matthias Kestenholz | Owner: nobody
Type: Bug | Status: new
Component: Core (System checks) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
(Adding Nick Pope to Cc: as author of the commit referenced below)
Since
https://github.com/django/django/commit/4400d8296d268f5a8523cd02ddc33b12219b2535
there is a system check which verifies that `LANGUAGES_BIDI` is a subset
of `LANGUAGES`. This breaks almost all installations of Django using a
custom `LANGUAGES` list which do not also override `LANGUAGES_BIDI` --
probably many installations.
All of them will either have to add a `LANGUAGES_BIDI` override or silence
`translation.E005` when updating. If this is intentional then this change
has to be mentioned in the release notes and documented somewhere.
However, I don't really see the need to verify that `LANGUAGES_BIDI` is a
subset of `LANGUAGES` and propose that the easiest and also the best way
to solve this is to remove the `translation.E005` check again.
Here's a test which currently fails but shouldn't in my opinion:
{{{
diff --git a/tests/check_framework/test_translation.py
b/tests/check_framework/test_translation.py
index 9a34b65c06..cea844988d 100644
--- a/tests/check_framework/test_translation.py
+++ b/tests/check_framework/test_translation.py
@@ -92,3 +92,7 @@ class TranslationCheckTests(SimpleTestCase):
self.assertEqual(check_language_settings_consistent(None), [
Error(msg, id='translation.E005'),
])
+
+ def test_languages_without_bidi(self):
+ with self.settings(LANGUAGE_CODE='en', LANGUAGES=[('en',
'English')]):
+ self.assertEqual(check_language_settings_consistent(None),
[])
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30342>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.1c8ea110c13f771d8019234dc2d75f2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
