#30646: close_if_unusable_or_obsolete fails to close unusable connections
-------------------------------------+-------------------------------------
Reporter: dneuhaeuser-zalando | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
Hello there,
> Fixing this does incur the cost of a roundtrip to the database with
every request but this doesn't appear to have any significant impact on
latency.
I'm afraid we can't take an anecdotical report about effects on your setup
to stand for most of other setups out there. What if someone reports that
it significantly affects ''their'' setup?
I guess we could add a flag to `close_if_unusable_or_obsolete` for this
purpose but it seems wasteful to perform this check on every request. If
we decide that this should be done we should at least move the ''
obsolescence '' check before the ''usable'' one since the former doesn't
require any database interactions and will be reached on all requests when
`CONN_MAX_AGE=0` which is the default.
--
Ticket URL: <https://code.djangoproject.com/ticket/30646#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/077.3ba0d0c46ecda8efe291345de79084a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
