#30802: Manifest file is updated when running collectstatic with --dry-run
-------------------------------------+-------------------------------------
Reporter: ryphill | Owner: nobody
Type: Bug | Status: new
Component: | Version: 1.11
contrib.staticfiles | Keywords:
Severity: Normal | ManifestStaticFilesStorage,
Triage Stage: | ManifestFilesMixin
Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
When running `collectstatic --dry-run` using `ManifestStaticFilesStorage`
as your static files storage the manifest file will always be updated.
This can be observed by running `python manage.py collectstatic` and then
`python manage.py collectstatic --dry-run` where you can see the
staticfiles.json file has been modified and the paths key in the json is
now empty.
It looks like the problem occurs in
[https://github.com/django/django/blob/1.11.24/django/contrib/staticfiles/storage.py#L416
ManifestFilesMixin.post_process] due to not checking the passed in value
of `dry_run` before calling `save_manifest`.
--
Ticket URL: <https://code.djangoproject.com/ticket/30802>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.ceb07a97bd2e60895ad8b5126a17c3a8%40djangoproject.com.
