#29138: Add ModelAdmin.autocomplete_fields support for ForeignKeys that use
to_field
-------------------------------+------------------------------------
     Reporter:  Jonathan Nye   |                    Owner:  schwtyl
         Type:  Bug            |                   Status:  assigned
    Component:  contrib.admin  |                  Version:  2.0
     Severity:  Normal         |               Resolution:
     Keywords:  autocomplete   |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  1
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by Johannes Hoppe):

 Hey Tyler,

 thanks for your swift response. I see, I wasn't ware of your background,
 but also didn't mean to offend you. I my comment really was only trying to
 save you some effort. I know first hand that the Django development
 process can be lengthy and demotivating.

 Anyhow, I see where you are coming from, and yes, you shouldn't absolutely
 use a mainstream Django version, to avoid security vulnerabilities.
 Might I suggest to use django-select2 until then? I developed and maintain
 that package, it was the blue print for Django's autocomplete field
 implementation, which I implemented too. It does work slightly different,
 but it will at least allow you to jump to a stable Django release.

 Regarding the patch: As the initial developer of this feature I have an
 elevated interest to solve all bugs, not just this one. That aside – IMHO
 – the best solution actually happens to fix both problems.

 I will do a review of your PR, to give you a bit better feeling of the
 work that would need to be done on the PR to fix only this issue. I'll let
 you decide, if you still think it's worth the effort given that all
 changes would need to be revered with the fix for #29138.

 Best
 -Joe

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29138#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e5c218d50c2b17ed118b909609925ce0%40djangoproject.com.

Reply via email to