#31160: admin base.css styling breaks nested ordered list numbering in admindocs
---------------------------------------------+------------------------
               Reporter:  owenh              |          Owner:  nobody
                   Type:  Bug                |         Status:  new
              Component:  contrib.admindocs  |        Version:  master
               Severity:  Normal             |       Keywords:
           Triage Stage:  Unreviewed         |      Has patch:  1
    Needs documentation:  0                  |    Needs tests:  0
Patch needs improvement:  0                  |  Easy pickings:  1
                  UI/UX:  0                  |
---------------------------------------------+------------------------
 == Summary

 Ordered lists are mistakenly styled with `list-style-type: square` when
 nested inside an unordered list. Thus, if an ordered list is nested inside
 an unordered list in a docstring, it is rendered incorrectly by admindocs.
 This is caused by the CSS rule in
 
[https://github.com/django/django/blob/24e540fbd71bd2b0843e751bde61ad0052a811b3/django/contrib/admin/static/admin/css/base.css#L97
 base.css, line 97]:

 {{{
 ul li { list-style-type: square; }
 }}}

 == Example

 {{{
 # models.py
 class Store(models.Model):
     """
     This model represents a store that has products available.

     - Unordered list item 1

       1. Ordered sub-list item 1

       2. Ordered sub-list item 2

     """
     pass
 }}}

 Expected behavior when rendered in browser:

 - Unordered list item 1
   1. Ordered sub-list item 1
   2. Ordered sub-list item 2

 Actual behavior when rendered in browser:

 - Unordered list item 1
   - Ordered sub-list item 1
   - Ordered sub-list item 2

 == Solution

 The CSS should apply only to list items directly inside an unordered list
 like this:

 {{{
 ul > li { list-style-type: square; }
 }}}

 See pull request: https://github.com/django/django/pull/12307

-- 
Ticket URL: <https://code.djangoproject.com/ticket/31160>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.997bde43b329c74a20d1dd6dfe4f4cc2%40djangoproject.com.

Reply via email to