#31358: Increase default password salt size in BasePasswordHasher.
--------------------------------------+------------------------------------
Reporter: Jon Moroney | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Florian Apolloner):
> I've updated the PR with what I think you mean. Let me know if that's
what you're thinking and I'll do the rest, else let me know what I
misunderstood :)
Yes that is what I ment.
> I think this can be handled in the BasePasswordHasher unless a hasher
implements its own must_update logic and in that case it must be on a case
by case basis.
Well the `must_update` methods in the hashers could call the base method
were appropriate. Ie instead of returning `False` when the hash thinks it
doesn't need an update it can call super().must_update
> I think it may just be easier to use len(salt) and handle the case where
salt is None.
Yes
--
Ticket URL: <https://code.djangoproject.com/ticket/31358#comment:32>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.459cb84c657e899f781f9fa9958e7e35%40djangoproject.com.
