#31358: Increase default password salt size in BasePasswordHasher.
--------------------------------------+------------------------------------
Reporter: Jon Moroney | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Jon Moroney):
> Well the `must_update` methods in the hashers could call the base method
were appropriate. Ie instead of returning `False` when the hash thinks it
doesn't need an update it can call super().must_update
In essence that makes for a two stage check I think. Should it just be
convention for a hasher to return `super().must_update` rather than ever
returning false?
After a bit of a struggle with the bcrypt hasher I've squashed it down to
a single commit. It looks like bcrypt is using more than just the salt
stored data as a salt in hash verification. I've added a bit more logic to
handle matching what was used, but if you wouldn't mind giving it a second
look that would be helpful :) I've left the relevant changes in the most
recent commit on the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/31358#comment:33>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.7533764c4327bd9c9f12b1d58a7f545f%40djangoproject.com.
