#32443: Remove shifted class from main when nav-sidebar is disabled.
-------------------------------+----------------------------------------
Reporter: Amir Ajorloo | Owner: Amir Ajorloo
Type: Uncategorized | Status: assigned
Component: Uncategorized | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Amir Ajorloo):
* owner: nobody => Amir Ajorloo
* status: new => assigned
Old description:
> I faced an issue in disabling the nav-sidebar. When I disable the nav-
> sidebar using `admin.site.enable_nav_sidebar = False`, the shifted
> class is still remaining, because this class is hard-coded in the main
> tag. Currently check both of shifted class of the main tag and the
> existence of the nav-sidebar together to apply the styles, but it can be
> more simple and prevent issues happening in the third-party modules.
>
> In the below screenshot, the nav-sidebar is enabled and it's open. So the
> main tag should have the shifted class to move its content to right:
> [[Image()]]
>
> In this screenshot, the nav-sidebar is enabled but it's close and the
> main tag doesn’t have the shifted class:
> [[Image()]]
>
> Bug
> In this screenshot, the nav-sidebar is disabled, but the main tag has
> shifted class (but it shouldn't):
> [[Image()]]
New description:
I faced an issue in disabling the nav-sidebar. When I disable the nav-
sidebar using `admin.site.enable_nav_sidebar = False`, the shifted
class is still remaining, because this class is hard-coded in the main
tag. Currently check both of shifted class of the main tag and the
existence of the nav-sidebar together to apply the styles, but it can be
more simple and prevent issues happening in the third-party modules.
In the below screenshot, the nav-sidebar is enabled and it's open. So the
main tag should have the shifted class to move its content to right:
[[Image(https://code.djangoproject.com/attachment/ticket/32443/Screen%20Shot%202021-02-11%20at%2020.05.07.png)]]
In this screenshot, the nav-sidebar is enabled but it's close and the main
tag doesn’t have the shifted class:
[[Image(https://code.djangoproject.com/attachment/ticket/32443/Screen%20Shot%202021-02-11%20at%2020.05.19.png)]]
Bug
In this screenshot, the nav-sidebar is disabled, but the main tag has
shifted class (but it shouldn't):
[[Image(https://code.djangoproject.com/attachment/ticket/32443/Screen%20Shot%202021-02-11%20at%2020.05.37.png)]]
--
--
Ticket URL: <https://code.djangoproject.com/ticket/32443#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.4ca59803345dde5516df9c08fa687db8%40djangoproject.com.
