#3275: [patch] select_related() additions (depth=N, fields=[])
------------------------------------------------+---------------------------
Reporter: David Cramer <[EMAIL PROTECTED]> | Owner: nobody
Status: new | Component:
Database wrapper
Version: SVN | Resolution:
Keywords: select_related() | Stage:
Accepted
Has_patch: 1 | Needs_docs: 1
Needs_tests: 1 | Needs_better_patch: 1
------------------------------------------------+---------------------------
Comment (by russellm):
Replying to [comment:20 Gábor Farkas <[EMAIL PROTECTED]>]:
>
> btw. my opinion is that this bug should get a little higher priority,
because without this patch select_related(depth) simply returns wrong
data,
> but probably different priorities for different people :-)
Caveat - I haven't looked into this particular issue or patch, and I
probably won't have a chance to in the near future (the "what gives"
comment just caught my ire).
However, you will find that the overwhelming philosophy of Django
development is that once a serious problem has been identified, we put all
of our efforts into fixing the underlying problem rather than patching a
solution known to be broken. The core developers have limited resources,
and every hour we spend identifying, inspecting and applying a partial fix
is an hour we don't spend fixing the underlying problem. Edit-inline is
one area where this is currently the case; anything touching querysets is
another.
> p.s: please note, that the "patch needs improvement" flag is probably
meant for the other patches in this ticket. the fix_depth_bug.diff patch
is a one-line-patch,
> which adds exactly one character. it's hard to imagine how such a patch
could be improved :)
It's also hard to know how the core developers are supposed to know this
without tracking every single comment on every single ticket. If there is
some subset of this ticket that constitutes a one character fix that needs
to be made, it should be a separate ticket describing the single issue
that will be resolved by applying the patch.
I should also point out that in reality, there isn't any such thing as a
'one character fix'. You need to convince me (or any other core developer)
that the one character fix is (1) required and (2) correct. You can't do
that in 1 character :-)
--
Ticket URL: <http://code.djangoproject.com/ticket/3275#comment:21>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
