#33667: Django admin stylesheet ignores --header-branding-color variable.
-------------------------------------+-------------------------------------
               Reporter:  Mike       |          Owner:  nobody
  DeSimone                           |
                   Type:  Bug        |         Status:  new
              Component:             |        Version:  3.2
  contrib.admin                      |       Keywords:
               Severity:  Normal     |  css,stylesheet,admin
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  1
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 In `contrib/admin/static/admin/css/base.css`, a header branding color
 variable is defined at line 20:

 {{{
   --header-branding-color: var(--accent);
 }}}

 but it is not used anywhere else. I expected it to be used in the branding
 h1 tags starting at line 920:

 {{{
 #branding h1 {
     padding: 0;
     margin: 0 20px 0 0;
     font-weight: 300;
     font-size: 24px;
     color: var(--accent);
 }

 #branding h1, #branding h1 a:link, #branding h1 a:visited {
     color: var(--accent);
 }
 }}}

 but as can be seen, `var(--accent)` is used instead. Also the second block
 redundantly calls out `#branding h1`. Any idea what it should have been?
 `#branding h1 a`?

 `--header-branding-color` appears nowhere else in Django. This bug is
 found in 3.2, 4.0, and the main branch.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33667>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701806c51c45d-4f107e9c-cd8c-4a0d-a23f-caccae4c2847-000000%40eu-central-1.amazonses.com.

Reply via email to