#33667: Django admin stylesheet ignores --header-branding-color variable.
--------------------------------------+------------------------------------
     Reporter:  Mike DeSimone         |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.admin         |                  Version:  3.2
     Severity:  Normal                |               Resolution:
     Keywords:  css,stylesheet,admin  |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by Mike DeSimone):

 > Unfortunately not, it doesn't qualify for a backport.

 Then making a patch is low priority for me. I'm going to have to override
 `#branding h1` directly anyway.

 Hmm, it seems `--accent` isn't used anywhere but these two places in
 `#branding`. Is this also an oversight? I'm wondering which fix is better:

 * use `--header-branding-color` in `#branding h1` and `--accent` in
 `#branding h1, #branding h1 a:link, #branding h1 a:visited` (changing the
 first `#branding h1` to `#branding h1 a`)
 * remove `--header-branding-color` as redundant, or
 * use `--accent` elsewhere?

 It's hard to say since I'm not the style designer.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33667#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701806c9790fd-05c38bc3-ee3f-42a0-8f2c-abb77f4ce068-000000%40eu-central-1.amazonses.com.

Reply via email to