#34322: ManifestStaticFilesStorage crashes on commented JavaScript import
statements
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 4.2
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:20 Sebastiaan Zeeff]:
> I'm also running into this problem and I don't thinks it's confined to
comments. Unfortunately, it only comes up when you really start working
with the 4.2b1 instead of just running test suites without running
`collectstatic`.
>
> I added a comment to the old issue (ten years old), but since discussion
is going on here as well, here's a link:
https://code.djangoproject.com/ticket/21080#comment:26
>
> I fear that this change in scanning for imports may break a lot more
projects and a lot of those project are probably using third-party
JavaScript/CSS dependencies that they can't easily change to circumvent
false positives in the import scanning procedure of Django. The third-
party package I'm using includes a widget that shows documentation,
including examples of imports in JavaScript strings, and it's probably not
the only third-party package that includes import examples somewhere in
files (either in comments or in the "empty states" of widgets that have
not been initialized yet).
Thanks for your comment. What do you think about
https://code.djangoproject.com/ticket/34322#comment:18?
--
Ticket URL: <https://code.djangoproject.com/ticket/34322#comment:21>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070186df59cea5-cc51c0eb-f638-4d7c-88a5-89630004759c-000000%40eu-central-1.amazonses.com.
