#34322: ManifestStaticFilesStorage crashes on commented JavaScript import
statements
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 4.2
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sebastiaan Zeeff):
Replying to [comment:24 Mariusz Felisiak]:
> It's a good option for end-users, although they'll have to discover the
option. The staticfiles error itself is probably going to be a bit
confusing, especially to less experienced users.
>
> The proposition is to make it opt-in not opt-out, so they'll have to
discover the option to turn it on. Moreover, it will be documented as
experimental with warning (already documented) about comments.
That means I misread the earlier conversation. I interpreted it as "it's
to late to make major changes to the behavior that's currently present in
the beta, but there's an opt-in patch that will solve issues for people
who are experience issues with the new import detection".
Apologies for taking up your time.
--
Ticket URL: <https://code.djangoproject.com/ticket/34322#comment:25>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070186dfcce11f-2567e116-d5a9-48a5-97cc-14221be3f331-000000%40eu-central-1.amazonses.com.
