#34580: Performance regession in SQLCompiler
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):
* cc: Simon Charette (added)
* type: Uncategorized => Cleanup/optimization
* component: Uncategorized => Database layer (models, ORM)
Comment:
Thanks for the report, can you point at the exact test definition that
regressed otherwise it's quite hard to confirm what actually got slower
Is this
[https://github.com/django/djangobench/blob/4c88fa81c4d7618604ae51e07c03c23f6734c2e6/djangobench/benchmarks/query_count/benchmark.py
query_count] and
[https://github.com/django/djangobench/blob/4c88fa81c4d7618604ae51e07c03c23f6734c2e6/djangobench/benchmarks/query_aggregate/benchmark.py#L12
aggregate]?
If that's the case then I'm surprised this particular commit caused a
regression in these `Count` tests as none of them make use or ordering. If
that's truly the culprit then it's likely only a matter of not generating
`selected_exprs` if there is no `ordering` in the first place.
--
Ticket URL: <https://code.djangoproject.com/ticket/34580#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701883eef7d58-c1561602-eae1-491a-9928-39d344f3e642-000000%40eu-central-1.amazonses.com.
