#34752: ASGI http.disconnect not handled for streaming responses
---------------------------------+------------------------------------
Reporter: Sam Toyer | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
Hey Sam, thanks for the report. Yes, please do open a PR! (It being the
weekend, I'd like to have a look at this properly once the PR is open.)
It would be nice to check that the cancelled error was handled explicitly,
[https://github.com/django/django/pull/16603/files#diff-
5f36804bb607499371385c6e3bbf30565150688c425d94ab0527af8af96a4f66R355 e.g.
in PR for #33738], and maybe add an example similar to the
[https://docs.djangoproject.com/en/dev/topics/async/#handling-disconnects
async views disconnect example] to the
[https://docs.djangoproject.com/en/dev/ref/request-response
/#streaminghttpresponse-objects StreamingHttpResponse docs].
--
Ticket URL: <https://code.djangoproject.com/ticket/34752#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070189a738af85-94944a47-cff5-4330-aff0-aefd3f22852a-000000%40eu-central-1.amazonses.com.
