#34752: ASGI http.disconnect not handled for streaming responses
---------------------------------+-------------------------------------
Reporter: Sam Toyer | Owner: Sam Toyer
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Release blocker | Resolution:
Keywords: async | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Comment (by Sam Toyer):
Filed a PR: https://github.com/django/django/pull/17147
One subtlety: I originally made a smaller modification to the handler that
put view logic and response logic in the same coroutine, but otherwise
followed the same flow. I found this broke in practice because sometimes
//both// coroutines would return at once. This caused the previous
`pending.pop()`/`done.pop()` logic to error out because one of those two
sets would be empty. I think that this problem is particularly likely to
happen in situations where some coroutines are long-lived. I haven't added
a test for this edge case yet, though.
--
Ticket URL: <https://code.djangoproject.com/ticket/34752#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070189bfb73e5d-b67c7cdc-b253-4c1c-a7ab-77130971546c-000000%40eu-central-1.amazonses.com.
