#34884: Half bug/half enhancement : inconsistent behavior of get_or_create()
regarding related attributes cache
-------------------------------------+-------------------------------------
Reporter: Laurent Lyaudet | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: wontfix
Keywords: ORM get_or_create | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* type: Uncategorized => Cleanup/optimization
* resolution: invalid => wontfix
Comment:
> where the silence closed the discussion.
Unfortunately Django cannot accommodate every feature request. If no one
finds your proposal compelling enough to respond, perhaps it is too niche.
In the mailing list thread you mentioned, I'm afraid that the lack of
indentation may have prevented some engagement. I guess the forum doesn't
suffer from that issue. I'm not active on the forum, but I have heard that
it's more active than the mailing list.
> I'm afraid that trying to make the ORM smarter about this might open a
can of worms.
What I meant is that other changes may be required to make created and
non-created model instances identical. The patch I offered already adds
non-trivial complexity and only handles foreign keys.
> And closing my ticket without an open discussion before is a kind of
slap in the face that is unfortunately current on the Internet.
I understand that it can come off that way, but as you see, a closed
ticket doesn't end the discussion. We don't like to leave tickets in an
untriaged state while the discussion takes place. I am going to change the
ticket resolution to "wontfix" because I think it's something that could
be changed if there is clear community consensus. I offer my opinion that
I don't think the proposal would be accepted, but no one is stopping you
from engaging further if this feature is important enough to you. A more
compelling proposal would address my doubt about whether or not foreign
key caching is the only difference between created and non-created model
instances.
--
Ticket URL: <https://code.djangoproject.com/ticket/34884#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018bc0a2efb1-41b612f2-b90e-4d9b-b83c-d34208eb9288-000000%40eu-central-1.amazonses.com.
