#35542: BoundField's label and help_text and renderer should be properties not
class members
-------------------------------------+-------------------------------------
Reporter: Christophe Henry | Owner:
Type: | Christophe Henry
Cleanup/optimization | Status: closed
Component: Forms | Version: dev
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):
Hello Christophe,
I understand your frustration, and I acknowledge the effort you've put
into writing tests and updating documentation for your PRs. It's clear
you've encountered challenges in achieving consensus on certain issues. As
mentioned, Django is a community-driven project, so contributions and
engagement vary based on availability and interest. To generate more
engagement in proposals and discussions:
* Clearly present the use case or need for change with a practical
example.
* Evaluate multiple solutions rather than focusing on a single
implementation.
* Seek input on potential framework-provided solutions that may not be
widely known.
Without these foundational steps, gaining attention and consensus can be
challenging. Given Django's maturity and widespread adoption, each
proposed change requires thorough evaluation and justification.
Specifically about this ticket, your proposed change in
[https://github.com/django/django/pull/18289 PR #18289] introduces a
breaking change, necessitating a clear deprecation plan and strong
rationale to justify it (think of those child classes that use `label` or
`help_text` as instance variables, and how assignments to these would
break when converted to properties). Furthermore, it's important to note
that you have not yet provided a reproducible case or detailed use case
explanation. These are essential for initiating meaningful discussions and
gaining broader community support.
--
Ticket URL: <https://code.djangoproject.com/ticket/35542#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701909d05286d-724c70c0-2554-4589-aa2a-e32466a00a46-000000%40eu-central-1.amazonses.com.
