#35935: sqlmigrate prevents normal colorization of system checks
-------------------------------------+-------------------------------------
     Reporter:  Jacob Walls          |                    Owner:  Jacob
         Type:                       |  Walls
  Cleanup/optimization               |                   Status:  assigned
    Component:  Core (Management     |                  Version:  dev
  commands)                          |
     Severity:  Normal               |               Resolution:
     Keywords:  no_color             |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted

Comment:

 Thank you Jacob, was able to reproduce adding something like this to an
 existing model (an FK with `unique=True`):

 {{{#!python
 user = models.ForeignKey("auth.User", unique=True,
 on_delete=models.CASCADE)
 }}}

 For the PR, do you think you could also provide a regression test where
 there is actually a warning system check emitted and then an assert that
 the system check is indeed colorized with your changes?
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35935#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019363879fc9-cfd00bbc-9784-4f43-aa29-72063e1deeb0-000000%40eu-central-1.amazonses.com.

Reply via email to