#7833: UserCreationForm doesn't handle the case where password1 is not set
-------------------------------------+--------------------------------------
Reporter: jvloothuis | Owner:
Status: new | Milestone: 1.0
Component: Authentication | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 1 |
-------------------------------------+--------------------------------------
Changes (by Mnewman):
* needs_better_patch: => 1
* needs_docs: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 1
* milestone: => 1.0
Comment:
This is clearly a problem. One thing about the patch in the test the data
passed through to the form would include {{{ password1 : '' }}}, because
the field is still on the page, there just isn't anything in it.
The other thing I would like to bring up is whether we would like the
password checking in clean_password2 or if we should have something that
more resembles [http://code.google.com/p/django-
registration/source/browse/trunk/registration/forms.py#61 django-
registration], which has it in the clean method and doesn't have this
problem.
--
Ticket URL: <http://code.djangoproject.com/ticket/7833#comment:1>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
