#35941: Add composite GenericForeignKey support
-------------------------------------+-------------------------------------
     Reporter:  Csirmaz Bendegúz     |                    Owner:  (none)
         Type:  New feature          |                   Status:  new
    Component:  Database layer       |                  Version:  dev
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):

 I think the proposal looks great Ben, thanks for creating this ticket.

 One thing that comes to mind as potentially problematic in JSON array
 comparison for `JOIN` is the treatment of Unicode characters as we're
 using `json.dumps(ensure_ascii=False)` as well as quotes and other
 characters that need to be escaped in JSON. It'd be great to add test
 coverage for these.

 As for the ''risks'' I appreciate you raising them but I think that
 supporting composite generic foreign key composed of standard members
 (int, date, datetime, uuid, text) is already a good stretch and I would
 feel comfortable saying that anything that falls in the exotic primary key
 category should not necessarily be supported in the first place.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35941#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701936bc315f9-23bcdecc-6f59-46b8-9491-59c70b96b506-000000%40eu-central-1.amazonses.com.

Reply via email to