#26007: SingleObjectTemplateResponseMixin.get_template_names does not return
names
stack properly.
-------------------------------+---------------------------------------
Reporter: Chris Cogdon | Owner: Andy Miller
Type: Bug | Status: assigned
Component: Generic views | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------------------------
Comment (by Andy Miller):
My personal feeling is the following on this is the following:
1. The docstring could be clearer about what is returned and in what order
depending on what is specified on the class
2. Given how list returned from this function is used, then I believe a
change could be made so that the code is purely additive to the list
generated rather than reseting which is the current case if
`template_name` is specified. This closer reflects the docstring
intention.
3. Improve the error messages, specifically the re raising of the previous
IncorrectlyConfigured is not correct since you can have other causes that
aren't clear from the error provided.
Based on the comment from Tim that would suggest the docstring should
remain despite the code implying otherwise in my reading of it.
I would suggest 3 smaller patches to deal with each of the points above
which depends on there being a consensus that all 3 changes are good to
do.
--
Ticket URL: <https://code.djangoproject.com/ticket/26007#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193b28a56cd-38da7a9c-e94b-4f70-b79b-5dd6f1a9b8a9-000000%40eu-central-1.amazonses.com.
