#36121: Allow customization of password_change_form in the Django admin site
-------------------------------------+-------------------------------------
Reporter: Mohammadreza | Owner:
Eskandari | Mohammadreza Eskandari
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: password_change | Triage Stage: Accepted
form, admin_site |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mohammadreza Eskandari):
Hi Natalia
Thank you so much for accepting my ticket and considering the changes!
I’ve created a GitHub repository to demonstrate the changes I’ve made in
relation to this ticket. In this repo, you will find a test project with
the necessary customizations for overriding the password_change_form as
discussed.
link of repository: https://github.com/mohammadrezaesk/django-ticket-36121
-show-case
**PR changes:**
Additionally, I’ve added test cases to the PR to check for security-
related changes, and I’ve updated the release notes and documentation as
requested 🫡.
Regarding the documentation, when I checked the existing docs for the
login_form customization, I noticed there were no detailed examples
provided for similar attributes. So, I followed the same format as the
login_form example and avoided adding unnecessary text. This way, the
documentation remains consistent with the current structure, and the
example is clear and concise.
Feel free to check out the project and let me know if further adjustments
are needed!
Looking forward to your feedback.
Replying to [comment:3 Natalia Bidart]:
> Thank you Mohammadreza Eskandari for taking the time to create this
ticket.
>
> Considering that we already have `password_change_template` and
`password_change_done_template` definitions in `AdminSite`, I'm inclined
to accept this ticket. But, I would need that a test project is shared so
you can showcase the concrete use case for this. Mohammadreza could you
please provide that?
>
> Specifically for the PR, it would need tests and proper docs for:
> 1. A small release note in the 6.0.txt file.
> 2. A somehow complete example in the docs of overriding the forms to
better exemplify its value (to be part of `/ref/contrib/admin/`).
--
Ticket URL: <https://code.djangoproject.com/ticket/36121#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701949500b231-d56d974a-3f59-4437-b7d5-d11bced98123-000000%40eu-central-1.amazonses.com.
