#36457: Convert methods .send_mail(), .get_users() from PasswordResetForm and .get_user() from PasswordResetConfirmView into functions. -------------------------------------+------------------------------------- Reporter: keter2002 | Owner: (none) Type: | Status: closed Cleanup/optimization | Component: contrib.auth | Version: dev Severity: Normal | Resolution: wontfix Keywords: users, email, | Triage Stage: PasswordResetForm, | Unreviewed PasswordResetConfirmView, auth, | method, id | Has patch: 0 | Needs documentation: 1 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 1 | UI/UX: 0 -------------------------------------+------------------------------------- Changes (by Sarah Boyce):
* resolution: => wontfix * status: new => closed Comment: As each can be called already doing `PasswordResetForm().send_mail()`, I personally don't see much reason to refactor here As this is suggesting a change to the API, you should propose and discuss this with the community. To do that, please raise this on the [https://github.com/django/new-features/issues new feature tracker]. I'll close the ticket for now, but if the community agrees with the proposal, please return to this ticket and reference the discussion so we can re-open it. For more information, please refer to [https://docs.djangoproject.com/en/stable/internals/contributing/bugs-and- features/#requesting-features the documented guidelines for requesting features]. -- Ticket URL: <https://code.djangoproject.com/ticket/36457#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/django-updates/0107019762e3ae0a-35cd0ac1-24d2-40e4-a2ca-0e2b47fd4b70-000000%40eu-central-1.amazonses.com.