#36439: Auth hashing blocks event loop if using asyncio
-------------------------------------+-------------------------------------
Reporter: Robert Aistleitner | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 5.2
Severity: Normal | Resolution:
Keywords: async, auth, | Triage Stage: Accepted
asyncio, performance |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
There appears to be a few things wrong with your current benchmark.
First you don't provide which hasher you used and and your setup steps
most importantly whether or not you first set a password for the users you
are testing against. If you didn't (e.g. you only set a username with an
invalid password) then it's highly likely all underlying `verify_password`
calls never get to the point of hashing `user.username` and then
performing a constant time compare which are the expensive operations CPU
wise that would benefit from executing in a thread pool.
Secondly the way you're iterating over each awaitable serially in a loop
prevents any concurrent scheduling execution from taking place thus you
most likely wouldn't notice if the event loop was blocked as you're only
processing one task at a time. You'd want to buffer up futures and await
them all so they can step on each others toes a bit if you hope to catch
any interference between them.
--
Ticket URL: <https://code.djangoproject.com/ticket/36439#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070197bedf6eb0-6e4200b4-2479-459e-a269-f52aff2516cf-000000%40eu-central-1.amazonses.com.
