#36571: Deprecated usage of BINARY expr in MySQL lookups
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Jason
Type: | Hall
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: mysql binary like | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jason Hall):
I've opened a draft PR for this change. At the moment, most of the test
suite passes using MySQL but I'm still seeing two failing tests:
`expressions.tests.ExpressionsTests.test_patterns_escape`
`expressions.tests.ExpressionsTests.test_insensitive_patterns_escape`
These both deal with `%` characters in expressions. Literal values
`("Article%")` behave correctly with escaping, but expressions like
`F("lastname")` containing `%` are failing.
I've tried a few different approaches to unify the escaping rules so
everything passes, but each time i fix one side it tends to blow up
elsewhere in the suite. Instead of continuing to hack away at this, I
thought i'd take a break and put up a PR in it's current state to get some
feedback.
--
Ticket URL: <https://code.djangoproject.com/ticket/36571#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070198e7707617-bd90eb20-ee5f-42e9-8fbe-09a357c770b1-000000%40eu-central-1.amazonses.com.
